Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit if error: describeTable with no parameters #1043

Merged

Conversation

felipe88alves
Copy link
Contributor

@felipe88alves felipe88alves commented Sep 22, 2022

Fix: #1029
Backlog Item #183159888

Proposal is to add validation of the length of the arguments passed to the DescribeTable function prior to any validation of the arguments itself.

There were no tests on equivalent DescribeTable errors (i.e.: MultipleEntryBodyFunctionsForTable and InvalidEntryDescription). I don't know if there's any history there or not, but following convention, I also did not add tests for this new error. I'll gladly take comments on that decision.

No document updates were made since this simply reflects current expected behaviour.

@onsi
Copy link
Owner

onsi commented Sep 26, 2022

thanks @felipe-alves-eric - yes these edges aren't particularly well-tested - but your approach here makes sense. a function with no inputs is invalid and this catches the issue identified in #1029 nicely.

@onsi onsi merged commit a4c9865 into onsi:master Sep 26, 2022
@felipe88alves
Copy link
Contributor Author

Thanks for the feedback @onsi!
I really enjoyed contributing, would it be ok for me to continue taking tasks in the backlog to help out?
And if so, do you recommend any task to take?

@onsi
Copy link
Owner

onsi commented Oct 18, 2022

hey @felipe88alves - sorry for missing this. Thanks for all the great work over on the MustPassRepeatedly decorator!

I'd love more help and if this flow of PRs/reviews is working for you we can think through a few other items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DescribeTable with no entries should fail
2 participants