Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream deprecation notice always displayed on windows #793

Closed
piksel opened this issue Apr 7, 2021 · 1 comment
Closed

Stream deprecation notice always displayed on windows #793

piksel opened this issue Apr 7, 2021 · 1 comment

Comments

@piksel
Copy link

piksel commented Apr 7, 2021

Running ginkgo v1.16 on windows always shows a deprecation notice, since the default value for --stream is true on windows:

c.FlagSet.BoolVar(&(c.ParallelStream), "stream", onWindows, "stream parallel test output in real time: less coherent, but useful for debugging")

This means that you have to add --stream=false to every command to not get the deprecation warnings, which are really distracting.
Perhaps adding a way to disable the warning globally and add that to the message, or disable the warning on windows? That is, if you cannot detect whether it was explicitly specified.

Example
$ ginkgo 
You're using deprecated Ginkgo functionality:
=============================================
Ginkgo 2.0 is under active development and will introduce (a small number of) breaking changes.
To learn more, view the migration guide at https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md
To comment, chime in at https://github.com/onsi/ginkgo/issues/711
  --stream is deprecated and will be removed in Ginkgo 2.0
  Learn more at: https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md#removed--stream

Running Suite: Example Suite
===========================
Random Seed: 1617791580
Will run 6 of 6 specs

++++++
Ran 6 of 6 Specs in 0.020 seconds
SUCCESS! -- 6 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 1.2055008s
Test Suite Passed
@onsi
Copy link
Owner

onsi commented Apr 7, 2021

Thanks for filing this - I'm going to remove the deprecation warning on Windows until there is something actionable for the user to do.

@onsi onsi closed this as completed in e4cff82 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants