Skip to content

Commit

Permalink
v1.16.1
Browse files Browse the repository at this point in the history
Supress deprecation warning for --stream on windows.
Fixes #793
  • Loading branch information
onsi committed Apr 7, 2021
1 parent c10c6b6 commit e4cff82
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
@@ -1,3 +1,8 @@
## 1.16.1

### Fixes
- Supress --stream deprecation warning on windows (#793)

## 1.16.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion config/config.go
Expand Up @@ -20,7 +20,7 @@ import (
"fmt"
)

const VERSION = "1.16.0"
const VERSION = "1.16.1"

type GinkgoConfigType struct {
RandomSeed int64
Expand Down
3 changes: 2 additions & 1 deletion ginkgo/run_command.go
Expand Up @@ -6,6 +6,7 @@ import (
"math/rand"
"os"
"regexp"
"runtime"
"strings"
"time"

Expand Down Expand Up @@ -56,7 +57,7 @@ func (r *SpecRunner) RunSpecs(args []string, additionalArgs []string) {

deprecationTracker := types.NewDeprecationTracker()

if r.commandFlags.ParallelStream {
if r.commandFlags.ParallelStream && (runtime.GOOS != "windows") {
deprecationTracker.TrackDeprecation(types.Deprecation{
Message: "--stream is deprecated and will be removed in Ginkgo 2.0",
DocLink: "removed--stream",
Expand Down
2 changes: 1 addition & 1 deletion types/deprecation_support.go
Expand Up @@ -81,7 +81,7 @@ func (d *DeprecationTracker) DeprecationsReport() string {
out += formatter.F("{{light-yellow}}============================================={{/}}\n")
out += formatter.F("Ginkgo 2.0 is under active development and will introduce (a small number of) breaking changes.\n")
out += formatter.F("To learn more, view the migration guide at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md{{/}}\n")
out += formatter.F("To comment, chime in at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/issues/711{{/}}\n")
out += formatter.F("To comment, chime in at {{cyan}}{{underline}}https://github.com/onsi/ginkgo/issues/711{{/}}\n\n")

for deprecation, locations := range d.deprecations {
out += formatter.Fi(1, "{{yellow}}"+deprecation.Message+"{{/}}\n")
Expand Down

0 comments on commit e4cff82

Please sign in to comment.