reporters/junit: Use `system-out` element instead of `passed` #769

dlipovetsky · 2021-02-10T19:06:58Z

Proposed fix for #768.

I would like to hear feedback from JUnit reporter users (or JUnit experts, familiar with the XML schema) before we consider merging this. Thanks!

In onsi#586, the JUnit reporter was extended to capture the output of passing tests when the -reportPassing flag is used. However, the passed element is not in the JUnit XML schema. While that alone might a theoretical problem, it is also a practical problem, because some parsers, e.g., the TeamCity XML Reporting Plugin JUnit parser, conform to that schema, ignore the element, and show no output for passing tests. The fix seems to be to use the system-out element instead. I have confirmed that, when using the system-out attribute, the TeamCity XML Reporting Plugin Junit parser shows output for a passing test.

onsi · 2021-02-10T20:35:00Z

LGTM!

onsi merged commit 9eda305 into onsi:master Feb 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reporters/junit: Use `system-out` element instead of `passed` #769

reporters/junit: Use `system-out` element instead of `passed` #769

dlipovetsky commented Feb 10, 2021 •

edited

onsi commented Feb 10, 2021

reporters/junit: Use system-out element instead of passed #769

reporters/junit: Use system-out element instead of passed #769

Conversation

dlipovetsky commented Feb 10, 2021 • edited

onsi commented Feb 10, 2021

reporters/junit: Use `system-out` element instead of `passed` #769

reporters/junit: Use `system-out` element instead of `passed` #769

dlipovetsky commented Feb 10, 2021 •

edited