Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GinkgoLogr #1067

Merged
merged 2 commits into from Oct 23, 2022
Merged

Add GinkgoLogr #1067

merged 2 commits into from Oct 23, 2022

Conversation

Nuckal777
Copy link
Contributor

Resolves #1063 .

@onsi
Copy link
Owner

onsi commented Oct 21, 2022

hey there this looks good. can you also update the docs (probably here is best: https://github.com/onsi/ginkgo/blob/master/docs/index.md#logging-output)

to mention GinkgoLogr?

Thanks!

@onsi
Copy link
Owner

onsi commented Oct 23, 2022

Looks good - thanks!

@onsi onsi merged commit bf78c28 into onsi:master Oct 23, 2022
@onsi onsi mentioned this pull request Mar 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement logr.LogSink for GingkoWriter
2 participants
@Nuckal777 @onsi