GinkgoLogr does not produce newlines

[erdnas]

GinkgoLogr.Info("Something")
GinkgoLogr.Info("Something else")

Outputs:

  Timeline >>
  "level"=0 "msg"="Something""level"=0 "msg"="Something else"
...

I would expect it to have a newline after each log call, for readability.

  Timeline >>
  "level"=0 "msg"="Something"
  "level"=0 "msg"="Something else"
...

If we add a newline to the printf here (or change it to println), we get newlines as desired.

ginkgo/internal/writer.go

Lines 136 to 140 in 9b5078f

	func GinkgoLogrFunc(writer *Writer) logr.Logger {
	return funcr.New(func(prefix, args string) {
	writer.Printf("%s", args)
	}, funcr.Options{})
	}

[onsi]

hey @Nuckal777 can you take a quick look at this. i know you implemented the logr stuff back in #1067 - is the newline being proposed here consistent with the logr spec?

[Nuckal777]

Good catch, we should a \n to the printf.