fix: install google-re2 with --only-binary option
#6129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6129 +/- ##
==========================================
+ Coverage 56.95% 57.04% +0.08%
==========================================
Files 506 506
Lines 30467 30935 +468
Branches 4592 4592
==========================================
+ Hits 17353 17646 +293
- Misses 12285 12464 +179
+ Partials 829 825 -4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: mayeut <mayeut@users.noreply.github.com>
justinchuby
added
the
run release CIs
cjvolzka
pushed a commit
that referenced
this pull request
May 6, 2024
### Description Only install google-re2 from wheels. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. It reverts #6120 which forced all dependencies to be available as wheels (psutil is not which forbids installing recent versions of jupyter/ipykernel). Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: mayeut <mayeut@users.noreply.github.com> (cherry picked from commit aa2cdac)
cjvolzka
pushed a commit
that referenced
this pull request
May 6, 2024
### Description Only install google-re2 from wheels. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. It reverts #6120 which forced all dependencies to be available as wheels (psutil is not which forbids installing recent versions of jupyter/ipykernel). Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: Matthieu Darbois <mayeut@users.noreply.github.com> (cherry picked from commit aa2cdac)
cjvolzka
pushed a commit
that referenced
this pull request
May 6, 2024
### Description Only install google-re2 from wheels. ### Motivation and Context The latest version of google-re2 dropped support for manylinux2014. google-re2 fails to build from sources thus failing the Linux release pipelines. This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014. It reverts #6120 which forced all dependencies to be available as wheels (psutil is not which forbids installing recent versions of jupyter/ipykernel). Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04). Signed-off-by: Matthieu Darbois <mayeut@users.noreply.github.com> (cherry picked from commit aa2cdac)
Merged
cjvolzka
added a commit
that referenced
this pull request
May 9, 2024
### Description
Check-pick commits from `main` into `rel-1.16.1` branch
### Motivation and Context
Fix 1.16.0 issues and enabled 1.16.1 builds by cherry-picking the
following PRs from `main` into the `1.16.1` branch
* Fixes since 1.16.0 release
* #6049
* #6048
* #6080
* #6122
* Update CI and Build to enable 1.16.1 builds
* #6106
* #6129
* #6075
* #6117
---------
Co-authored-by: liqun Fu <liqfu@microsoft.com>
Co-authored-by: G. Ramalingam <grama@microsoft.com>
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only install google-re2 from wheels.
Motivation and Context
The latest version of google-re2 dropped support for manylinux2014.
google-re2 fails to build from sources thus failing the Linux release pipelines.
This PR forces installation from wheels on manylinux which thus fallback on the latest version of google-re2 with a wheel for manylinux2014.
It reverts #6120 which forced all dependencies to be available as wheels (psutil is not which forbids installing recent versions of jupyter/ipykernel).
Another solution would be to bump the manylinux images to manylinux_2_28 but that could have impact on downstream users (e.g. impossible to install wheel from rh7, amazon linux 2, ubuntu 18.04).