Allow ReferenceEvaluator to return intermediate results #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6066 +/- ##
==========================================
+ Coverage 56.95% 56.97% +0.02%
==========================================
Files 506 506
Lines 30467 30483 +16
Branches 4592 4593 +1
==========================================
+ Hits 17353 17369 +16
Misses 12285 12285
Partials 829 829 ☔ View full report in Codecov by Sentry. |
justinchuby
approved these changes
Apr 3, 2024
justinchuby
reviewed
Apr 3, 2024
|
lgtm |
gramalingam
approved these changes
Apr 4, 2024
gramalingam
pushed a commit
to gramalingam/onnx
that referenced
this pull request
Apr 12, 2024
### Description Intermediate results can only be printed right now. With this PR, they can be returned as well. ### Motivation and Context See onnx#6025. --------- Signed-off-by: Xavier Dupre <xadupre@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Intermediate results can only be printed right now. With this PR, they can be returned as well.
Motivation and Context
See #6025.