Prevent crash on import after GCC 8 builds #6048
Merged
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Volzka <cjvolzka@us.ibm.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6048 +/- ##
==========================================
+ Coverage 56.95% 56.97% +0.02%
==========================================
Files 506 506
Lines 30467 30483 +16
Branches 4592 4593 +1
==========================================
+ Hits 17353 17369 +16
Misses 12285 12285
Partials 829 829 ☔ View full report in Codecov by Sentry. |
|
Thanks. Looks ok to me, but I am not a cmake expert either ... would be good to get a review from someone knowledgeable in cmake. |
xadupre
reviewed
Apr 4, 2024
thiagocrepaldi
approved these changes
Apr 4, 2024
Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com> Signed-off-by: Charles Volzka <42243335+cjvolzka@users.noreply.github.com>
edgchen1
approved these changes
Apr 8, 2024
justinchuby
approved these changes
Apr 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
gramalingam
added a commit
to gramalingam/onnx
that referenced
this pull request
Apr 12, 2024
### Description Possible fix for onnx#6047 based on https://stackoverflow.com/questions/33149878/experimentalfilesystem-linker-error/33159746#33159746 ### Motivation and Context I'm not a cmake expert so there may be a better way to do this. This did allow me to build ONNX 1.16 on RHEL 8. --------- Signed-off-by: Charles Volzka <cjvolzka@us.ibm.com> Signed-off-by: Charles Volzka <42243335+cjvolzka@users.noreply.github.com> Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
gramalingam
added a commit
to gramalingam/onnx
that referenced
this pull request
Apr 12, 2024
### Description Possible fix for onnx#6047 based on https://stackoverflow.com/questions/33149878/experimentalfilesystem-linker-error/33159746#33159746 ### Motivation and Context I'm not a cmake expert so there may be a better way to do this. This did allow me to build ONNX 1.16 on RHEL 8. --------- Signed-off-by: Charles Volzka <cjvolzka@us.ibm.com> Signed-off-by: Charles Volzka <42243335+cjvolzka@users.noreply.github.com> Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
cjvolzka
added a commit
that referenced
this pull request
Apr 29, 2024
### Description Possible fix for #6047 based on https://stackoverflow.com/questions/33149878/experimentalfilesystem-linker-error/33159746#33159746 ### Motivation and Context I'm not a cmake expert so there may be a better way to do this. This did allow me to build ONNX 1.16 on RHEL 8. --------- Signed-off-by: Charles Volzka <cjvolzka@us.ibm.com> Signed-off-by: Charles Volzka <42243335+cjvolzka@users.noreply.github.com> Co-authored-by: Thiago Crepaldi <thiago.crepaldi@microsoft.com> Co-authored-by: G. Ramalingam <grama@microsoft.com> (cherry picked from commit 3f24ef3)
Merged
cjvolzka
added a commit
that referenced
this pull request
May 9, 2024
### Description
Check-pick commits from `main` into `rel-1.16.1` branch
### Motivation and Context
Fix 1.16.0 issues and enabled 1.16.1 builds by cherry-picking the
following PRs from `main` into the `1.16.1` branch
* Fixes since 1.16.0 release
* #6049
* #6048
* #6080
* #6122
* Update CI and Build to enable 1.16.1 builds
* #6106
* #6129
* #6075
* #6117
---------
Co-authored-by: liqun Fu <liqfu@microsoft.com>
Co-authored-by: G. Ramalingam <grama@microsoft.com>
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Possible fix for #6047 based on https://stackoverflow.com/questions/33149878/experimentalfilesystem-linker-error/33159746#33159746
Motivation and Context
I'm not a cmake expert so there may be a better way to do this. This did allow me to build ONNX 1.16 on RHEL 8.