Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swish operator #5964
base: main
Are you sure you want to change the base?
Add Swish operator #5964
Changes from all commits
7691a35
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 4 in onnx/backend/test/case/node/swish.py
Codecov / codecov/patch
onnx/backend/test/case/node/swish.py#L4
Check warning on line 6 in onnx/backend/test/case/node/swish.py
Codecov / codecov/patch
onnx/backend/test/case/node/swish.py#L6
Check warning on line 10 in onnx/backend/test/case/node/swish.py
Codecov / codecov/patch
onnx/backend/test/case/node/swish.py#L8-L10
Check warning on line 14 in onnx/backend/test/case/node/swish.py
Codecov / codecov/patch
onnx/backend/test/case/node/swish.py#L13-L14
Check warning on line 18 in onnx/backend/test/case/node/swish.py
Codecov / codecov/patch
onnx/backend/test/case/node/swish.py#L17-L18
Check warning on line 20 in onnx/backend/test/case/node/swish.py
Codecov / codecov/patch
onnx/backend/test/case/node/swish.py#L20
Check warning on line 27 in onnx/backend/test/case/node/swish.py
Codecov / codecov/patch
onnx/backend/test/case/node/swish.py#L26-L27
Check warning on line 29 in onnx/backend/test/case/node/swish.py
Codecov / codecov/patch
onnx/backend/test/case/node/swish.py#L29
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beta is missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are using SiLU I'm assuming beta is 1.0? I can add it tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice HardSwish uses alpha and beta in the form
alpha*x + beta
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on #5964 (comment) I will add
beta
and rename the operator toswish
, thanks for reviewing this!