New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: start with pipeline for official release (without manual steps) #5939
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5939 +/- ##
=======================================
Coverage 56.81% 56.81%
=======================================
Files 506 506
Lines 30370 30370
Branches 4592 4592
=======================================
Hits 17256 17256
Misses 12285 12285
Partials 829 829 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
It is beneficial of publish to pypi without need of access to pypi. |
Signed-off-by: Andreas Fehlner <fehlner@arcor.de>
release: | ||
name: Release | ||
runs-on: ubuntu-latest | ||
if: github.event_name == 'release' && github.event.action == 'published' && startsWith(github.ref, 'refs/tags/v') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need the commit to be in an rel-* branch I think?
- name: Create GitHub Release # TODO: notes? | ||
env: | ||
GITHUB_TOKEN: ${{ github.token }} | ||
run: >- | ||
gh release create ''${{ github.ref_name }}' --repo '${{ github.repository }}' --notes "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can assume a release has been created when this pipeline is triggered, because we use the release feature to create the tag.
…b.com/andife/onnx into create_release_directly_from_pipeline
Description
Remove manual steps for the official release build.
Motivation and Context
#5927
Open points? Points to discuss?
I see a few different options we have maybe. Maybe the "most critical" point is publishing to pypi, as we cannot undo that.
Option A): Create a tag from the github webinterface
Option B ): Create a release from the github webinterface.
Option C): Split Tag creation and release