Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotating the return variables #5935

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abhishek-TyRnT
Copy link
Contributor

Description

added typecheck for lstm.py file.

Motivation and Context
passes mypy conditions
#4399

Signed-off-by: Abhishek-TyRnT <kulkarnia168@gmail.com>
@Abhishek-TyRnT Abhishek-TyRnT requested a review from a team as a code owner February 14, 2024 11:13
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (dba666c) 56.64% compared to head (21ea9f4) 56.64%.

Files Patch % Lines
onnx/backend/test/case/node/lstm.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5935      +/-   ##
==========================================
- Coverage   56.64%   56.64%   -0.01%     
==========================================
  Files         506      506              
  Lines       30201    30204       +3     
  Branches     4558     4558              
==========================================
  Hits        17108    17108              
- Misses      12268    12271       +3     
  Partials      825      825              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is desired as it is unnecessarily verbose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review in progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants