op function body not to allow default opset version #5908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5908 +/- ##
=======================================
Coverage 56.81% 56.81%
=======================================
Files 506 506
Lines 30370 30370
Branches 4592 4592
=======================================
Hits 17256 17256
Misses 12285 12285
Partials 829 829 ☔ View full report in Codecov by Sentry. |
gramalingam
reviewed
Feb 6, 2024
|
|
||
| bool BuildContextDependentFunction( | ||
| const FunctionBodyBuildContext& ctx, | ||
| FunctionProto& function_proto, | ||
| int requested_opset_version = OpSchema::kUninitializedSinceVersion) const; |
There was a problem hiding this comment.
Wondering: is OpSchema::kUninitializedSinceVersion used anywhere else, or can it be removed?
gramalingam
reviewed
Feb 6, 2024
| @@ -699,21 +699,14 @@ void OpSchema::ParseAndSetTypes( | |||
| OpSchema& OpSchema::SetContextDependentFunctionBodyBuilder( | |||
| ContextDependentFunctionBodyBuilder functionBuilder, | |||
| int opset_version) { | |||
| if (opset_version == OpSchema::kUninitializedSinceVersion && since_version_ != OpSchema::kUninitializedSinceVersion) { | |||
There was a problem hiding this comment.
nit: I wonder if we should have an assert to ensure that opset_verion is > 0 (that is, not equal to OpSchema::kUninitializedSinceVersion)? Just to catch it if user passes that value?
There was a problem hiding this comment.
Good question - we had a similar discussion in #5906 (comment) as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OpSchema::FunctionBody, OpSchema::SetContextDependentFunctionBodyBuilder, and OpSchema::BuildContextDependentFunction used to have since_version as the default opset_version. This poses an issue for custom ops. Make opset version a required argument so that there is no ambiguity.
Motivation and Context
to enhance validity of function bodies. Need to validate with Ort before merge. It PR will be merged after 1.16.0 release.