[experimental] Test move-support for proto #5575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,53 @@ | |||
| // Copyright (c) ONNX Project Contributors | |||
Check warning
Code scanning / lintrunner
CLANGFORMAT/format Warning
liqunfu
approved these changes
Sep 14, 2023
jcwchen
reviewed
Sep 14, 2023
There was a problem hiding this comment.
Conclude our offline discussion here:
- The CI failure might be related to Protobuf version. The failed Linux is using Protobuf 3.6.1 from Ubuntu 20.04's
apt-get install libprotobuf-dev protobuf-compiler. - 3 possible approaches
- Detect Protobuf version when using move-support for proto
- Bump Ubuntu version in Linux CI (Ubuntu 20.04 to 22.04), whose Protobuf version from apt-get version is 3.12.4. Not sure whether Protobuf 3.12.4 will work with move-support for proto though. Also note that Ubuntu 20.04 is still a popular/supported version.
- Drop that test for using apt-get's Protobuf in Linux CI, but in that case Ubuntu 20.04 users cannot build ONNX with Protobuf from apt-get anymore. It might make sense since actually other CIs are using higher Protobuf versions (3.20+)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test. Please do not merge.
Testing move-support for proto objects in all platforms/versions tested by CI.