Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Split-20 - change uneven split behavior to be more torch-like #5321

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Add Split-20 - change uneven split behavior to be more torch-like #5321

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6db44ff
Add Split20
p-wysocki Jun 15, 2023
9c6938f
Minor change
p-wysocki Jun 15, 2023
2aa2fd1
Merge remote-tracking branch 'upstream/main' into split20
p-wysocki Jul 6, 2023
3b8cfca
Rename mode to minimize_diff
p-wysocki Jul 6, 2023
aab6d3f
attempt to fix build
p-wysocki Jul 6, 2023
b0010da
Merge remote-tracking branch 'upstream/main' into split20
p-wysocki Sep 22, 2023
a911415
some CR changes
p-wysocki Sep 22, 2023
4a0ab8e
Update docs
p-wysocki Sep 22, 2023
7c50c89
hopefully fix build on CI
p-wysocki Sep 22, 2023
2587995
CI:apply auto updated documentation/backend test data
p-wysocki Sep 22, 2023
6d57f33
Merge remote-tracking branch 'upstream/main' into split20
p-wysocki Oct 3, 2023
c5c6a75
Try to fix compilation on CI
p-wysocki Oct 3, 2023
a39060b
cast vector size to int64
p-wysocki Oct 3, 2023
9a4b19e
Change attribute to req, add tests
p-wysocki Oct 5, 2023
9af3089
remove whitespaces
p-wysocki Oct 5, 2023
aed30e7
CI:apply auto updated documentation/backend test data
p-wysocki Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion onnx/defs/tensor/defs.cc
View file
Open in desktop
Expand Up @@ -676,7 +676,7 @@
between the number of elements in the output tensors is minimized, which
results in the last few dimensions' sizes being lowered by one.
If 'minimize_diff' is set to 'false', the last output tensors will be emptied in order to
accomodate for the missing values.

Check warning on line 679 in onnx/defs/tensor/defs.cc

View workflow job for this annotation

GitHub Actions / Optional Lint 

[misspell] reported by reviewdog 🐶
"accomodate" is a misspelling of "accommodate"

Raw Output:
./onnx/defs/tensor/defs.cc:679:0: "accomodate" is a misspelling of "accommodate"
)DOC";

ONNX_OPERATOR_SET_SCHEMA(
Expand Down Expand Up @@ -753,7 +753,7 @@
if (ctx.hasInput(1) && num_outputs_attr) {
fail_shape_inference("Both 'split' input and 'num_outputs' attribute were given");
}
if (ctx.hasInput(1)) { // 'split' is input

Check warning on line 756 in onnx/defs/tensor/defs.cc

View workflow job for this annotation

GitHub Actions / Optional Lint 

[cpplint] reported by reviewdog 🐶
 At least two spaces is best between code and comments  [whitespace/comments] [2]

Raw Output:
onnx/defs/tensor/defs.cc:756:  At least two spaces is best between code and comments  [whitespace/comments] [2]
auto split_proto = ctx.getInputData(1);
if (split_proto == nullptr) {
// skip if split is not an initializer
Expand All @@ -778,7 +778,7 @@
}
} else { // no value available for 'split'
if (num_outputs_attr) {
const int num_outputs = num_outputs_attr->i();
const long int num_outputs = num_outputs_attr->i();

Check warning on line 781 in onnx/defs/tensor/defs.cc

View workflow job for this annotation

GitHub Actions / Optional Lint 

[cpplint] reported by reviewdog 🐶
 Use int16/int64/etc, rather than the C type long  [runtime/int] [4]

Raw Output:
onnx/defs/tensor/defs.cc:781:  Use int16/int64/etc, rather than the C type long  [runtime/int] [4]
p-wysocki marked this conversation as resolved.
Show resolved Hide resolved
if (num_outputs < 1) {
fail_shape_inference("Attribute `num_outputs` value cannot be lower than 1");
}
Expand All @@ -790,7 +790,7 @@
int chunk_size = split_dim_value / num_outputs;
if (minimize_diff) {
int reduced_dims = num_outputs * (chunk_size + 1) - split_dim_value;
for (int i=0; i<num_outputs-reduced_dims; i++) {

Check warning on line 793 in onnx/defs/tensor/defs.cc

View workflow job for this annotation

GitHub Actions / Optional Lint 

[cpplint] reported by reviewdog 🐶
 Missing spaces around <  [whitespace/operators] [3]

Raw Output:
onnx/defs/tensor/defs.cc:793:  Missing spaces around <  [whitespace/operators] [3]
split.push_back(chunk_size+1);
}
while (split.size() <= num_outputs) {
Expand Down