infer old squeeze on known input shape and empty axes #5283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: daquexian <daquexian566@gmail.com>
daquexian
added a commit
to onnx/optimizer
that referenced
this pull request
Jun 4, 2023
Signed-off-by: daquexian <daquexian566@gmail.com>
xadupre
reviewed
Jun 5, 2023
| if (!ctx.getInputType(0)->tensor_type().has_shape()) { | ||
| return; | ||
| } | ||
|
|
||
| ctx.getOutputType(0)->mutable_tensor_type()->mutable_shape(); | ||
| const auto& input_shape = ctx.getInputType(0)->tensor_type().shape(); | ||
| const auto input_ndim = input_shape.dim_size(); |
There was a problem hiding this comment.
That seems to be the same code than above, could it be moved in one separate function?
gramalingam
reviewed
Jun 5, 2023
| operatorsetid.domain = "" | ||
| operatorsetid.version = 11 | ||
| self._assert_inferred( | ||
| graph, [make_tensor_value_info("y", TensorProto.FLOAT, (3, 2))] |
There was a problem hiding this comment.
I guess that the opset needs to be specified, eg., something like opset_imports=[helper.make_opsetid(ONNX_DOMAIN, 11)]
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the shape inference of squeeze 13 can handle the case that the input shape is known and the axes is unspecified, but that of older version squeezes not. This PR fixes it.