upgrading libp2p to version v0.14.1 #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
- Coverage 56.42% 56.38% -0.05%
==========================================
Files 423 423
Lines 24783 24779 -4
==========================================
- Hits 13984 13971 -13
- Misses 8907 8911 +4
- Partials 1892 1897 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
vishalchangrani
commented
Jun 4, 2021
| @@ -458,10 +458,7 @@ func blockEventsToMessage(block flow.BlockEvents) (*access.EventsResponse_Result | |||
| for i, event := range block.Events { | |||
| eventMessages[i] = convert.EventToMessage(event) | |||
| } | |||
| timestamp, err := ptypes.TimestampProto(block.BlockTimestamp) | |||
There was a problem hiding this comment.
vishalchangrani
commented
Jun 4, 2021
| @@ -27,14 +27,15 @@ require ( | |||
| github.com/ipfs/go-log v1.0.4 | |||
| github.com/jrick/bitset v1.0.0 | |||
| github.com/libp2p/go-addr-util v0.0.2 | |||
| github.com/libp2p/go-libp2p v0.13.0 | |||
| github.com/libp2p/go-libp2p-core v0.8.0 | |||
| github.com/libp2p/go-libp2p v0.14.1 | |||
There was a problem hiding this comment.
the crux of the change - go-libp2p
zhangchiqing
approved these changes
Jun 4, 2021
yhassanzadeh13
approved these changes
Jun 4, 2021
vishalchangrani
added a commit
that referenced
this pull request
Jun 4, 2021
vishalchangrani
added a commit
that referenced
this pull request
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libp2p v0.14.1
The
stream reseterror that are being reported on mainnet and devnet could be because of the yamux issue.This change -
go mod tidy.ptypes.TimestampProtomethod withtimestamppb.New.