[EFM] Transition to committed epoch in EFM #5898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/efm-recovery #5898 +/- ##
========================================================
- Coverage 57.63% 55.61% -2.03%
========================================================
Files 867 1134 +267
Lines 68038 89665 +21627
========================================================
+ Hits 39217 49868 +10651
- Misses 25129 34997 +9868
- Partials 3692 4800 +1108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AlexHentschel
approved these changes
May 14, 2024
state/protocol/protocol_state/epochs/fallback_statemachine_test.go
Outdated
Show resolved
Hide resolved
state/protocol/protocol_state/epochs/fallback_statemachine_test.go
Outdated
Show resolved
Hide resolved
state/protocol/protocol_state/epochs/fallback_statemachine_test.go
Outdated
Show resolved
Hide resolved
state/protocol/protocol_state/epochs/fallback_statemachine_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Hentschel <alex.hentschel@flowfoundation.org>
Co-authored-by: Alexander Hentschel <alex.hentschel@flowfoundation.org>
…t.go Co-authored-by: Alexander Hentschel <alex.hentschel@flowfoundation.org>
…w/flow-go into yurii/5726-maintaining-efm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5726
Context
Previously we could maintain EFM only if we have entered it in staking or setup phases, if we have entered EFM when next epoch has been already committed then we wouldn't perform epoch transition because
FallbackStateMachineignored request for transition to the next epoch.This PR updates
FallbackStateMachineto use the same logic for epoch transitions as the happy path. Additionally activated previously disabled tests and restructured logic.