Add new TPS loader load type: EVM batch transfer #5879
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezpodhostnik
requested review from
zhangchiqing,
ramtinms,
sideninja and
peterargue
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5879 +/- ##
==========================================
+ Coverage 55.62% 55.84% +0.22%
==========================================
Files 1134 1131 -3
Lines 89623 89556 -67
==========================================
+ Hits 49853 50013 +160
+ Misses 34981 34774 -207
+ Partials 4789 4769 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
approved these changes
May 9, 2024
peterargue
reviewed
May 10, 2024
| } | ||
|
|
||
| func (l *EVMBatchTransferLoad) Load(log zerolog.Logger, lc LoadContext) error { | ||
| select { |
There was a problem hiding this comment.
is there a way to gracefully shutdown?
| var _ io.Closer = (*EVMBatchTransferLoad)(nil) | ||
|
|
||
| func (l *EVMBatchTransferLoad) Close() error { | ||
| close(l.eoaChan) |
There was a problem hiding this comment.
closing this async will probably result in random panics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5745
Added
evm-batch-transferload to do multiple EVM transfers within one FVM transaction