[Execution] Add ingestion core tests #5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5871 +/- ##
==========================================
+ Coverage 55.61% 55.79% +0.17%
==========================================
Files 1128 1128
Lines 88951 88955 +4
==========================================
+ Hits 49470 49629 +159
+ Misses 34776 34590 -186
- Partials 4705 4736 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
force-pushed
the
leo/add-ingestion-core-tests
branch
from
c2b33e0
to
356b891
Compare
zhangchiqing
force-pushed
the
leo/add-ingestion-core-tests
branch
from
356b891
to
d9717d4
Compare
janezpodhostnik
approved these changes
May 17, 2024
sideninja
reviewed
May 17, 2024
| type mockConsumer struct { | ||
| sync.Mutex | ||
| executed map[flow.Identifier]struct{} | ||
| wgs map[flow.Identifier]*sync.WaitGroup |
There was a problem hiding this comment.
should access to this be synced?
sideninja
approved these changes
May 17, 2024
zhangchiqing
force-pushed
the
leo/add-ingestion-core-tests
branch
from
d9717d4
to
24f6536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test cases for ingestion core engine and metrics.