[Access] Added highest indexed height to metadata #5832
+333
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5832 +/- ##
==========================================
+ Coverage 55.83% 55.85% +0.01%
==========================================
Files 1129 1130 +1
Lines 89260 89230 -30
==========================================
- Hits 49841 49835 -6
+ Misses 34667 34643 -24
Partials 4752 4752
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
reviewed
May 6, 2024
…isarchuk/4757-current-indexed-height
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
….com:The-K-R-O-K/flow-go into AndriiSlisarchuk/4757-current-indexed-height
peterargue
reviewed
May 10, 2024
…isarchuk/4757-current-indexed-height
peterargue
reviewed
May 21, 2024
peterargue
reviewed
May 27, 2024
| return nil, rpc.ConvertIndexError(err, lastFinalizedHeader.Height, "could not get highest indexed height") | ||
| } | ||
|
|
||
| metadata.HighestIndexedHeight = highestIndexedHeight |
There was a problem hiding this comment.
we should treat the return value from HighestIndexedHeight as undefined when an error is returned, and explicitly set the value to 0. this makes the intention clear for the next reader, and avoids hard to debug issues in the future if the implementation ever changes.
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4757
Added highest indexed height field to Access API endpoints metadata.