Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding instrumentation for script execution in compatibility mode for… #5467

Open
wants to merge 3 commits into
base: v0.33
Choose a base branch
from

Conversation

vishalchangrani
Copy link
Contributor

@vishalchangrani vishalchangrani commented Feb 27, 2024

… access node

I do not plan to merge this into v0.33 but instead just use it to gather more data around script execution.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 55.53%. Comparing base (d2c9303) to head (b8180fd).

Files Patch % Lines
engine/access/rpc/backend/script_comparer.go 42.10% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.33    #5467      +/-   ##
==========================================
+ Coverage   55.52%   55.53%   +0.01%     
==========================================
  Files         995      996       +1     
  Lines       95835    95923      +88     
==========================================
+ Hits        53215    53275      +60     
- Misses      38636    38665      +29     
+ Partials     3984     3983       -1     
Flag Coverage Δ
unittests 55.53% <42.10%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishalchangrani vishalchangrani self-assigned this Feb 27, 2024
Copy link
Contributor

@peterargue peterargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants