add block id to protocol state #5328
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
commented
Jan 31, 2024
| @@ -698,8 +698,7 @@ func (state *State) Final() protocol.Snapshot { | |||
| // - exception for critical unexpected storage errors | |||
| func (state *State) AtHeight(height uint64) protocol.Snapshot { | |||
| // retrieve the block ID for the finalized height | |||
| var blockID flow.Identifier | |||
| err := state.db.View(operation.LookupBlockHeight(height, &blockID)) | |||
| blockID, err := state.headers.BlockIDByHeight(height) | |||
There was a problem hiding this comment.
Same DB operation, except it reuses the cache from the headers module
zhangchiqing
commented
Jan 31, 2024
| @@ -210,7 +210,7 @@ func (e *Engine) BlockProcessable(b *flow.Header, _ *flow.QuorumCertificate) { | |||
| return | |||
| } | |||
|
|
|||
| blockID := b.ID() | |||
| blockID := qc.BlockID | |||
There was a problem hiding this comment.
The caller guarantees the qc is for the block ID, this allows us to save a ID() call
zhangchiqing
force-pushed
the
leo/add-block-id-to-state
branch
from
fae702c
to
a45d1a1
Compare
zhangchiqing
commented
Jan 31, 2024
| @@ -72,6 +72,10 @@ func (s *Snapshot) Head() (*flow.Header, error) { | |||
| return head, err | |||
| } | |||
|
|
|||
| func (s *Snapshot) BlockID() (flow.Identifier, error) { | |||
There was a problem hiding this comment.
Some modules already depend on protocol state, however, they still import storage.Headers, because they need to find blockID by height using the headers.BlockIDByHeight method.
With the BlockID method added to snapshot along with the changes in the AtHeight method as below, we could use state.AtHeight(height).BlockID() to replace headers.BlockIDByHeight, which has been used a lot, and remove the dependency on storage.Headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.