Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure and report code coverage #899

Merged
merged 1 commit into from May 13, 2021
Merged

Measure and report code coverage #899

merged 1 commit into from May 13, 2021

Conversation

turbolent
Copy link
Member

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker
Copy link
Member

It looks like codecov-action@v1 includes version 1.5. It includes codecov/codecov-action#299 so it no longer requests the bash script from codecov.io. 👍

codecov/codecov-action#299 (comment) says it's part of the remediation for the previously hacked bash uploader script.

this change set is in fact related and is part of the remediation. The Codecov Action for uploading coverage results was impacted. I would recommend reaching out to security@codecov.io for any specific questions.

Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I didn't spot anything obvious.

@@ -34,6 +36,11 @@ jobs:
run: make test
- name: Check tidy
run: make check-tidy
- name: Upload coverage report
uses: codecov/codecov-action@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like codecov-action@v1 includes version 1.5. It includes codecov/codecov-action#299 so it no longer requests the bash script from codecov.io. 👍

@turbolent turbolent merged commit ede5edf into master May 13, 2021
@turbolent turbolent deleted the bastian/code-coverage branch May 13, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants