Wrap host-function typed member-values with a bound-function #3342
+2,911
−2,081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 8b6e4b6 Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
6 tasks
6 tasks
Add back transaction `execute` tests
turbolent
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards https://github.com/dapperlabs/cadence-internal/issues/215
Description
Wraps host-function with a bound function, when accessing members of containers (arrays, dictionaries, and composites), if they are function-typed members.
This is already done for user-defined functions (interpreted functions) of composites. So this PR is basically extending the same for native functions (host functions) as well, and for other types of containers.
Note:
I refactored the code to create bound functions for all native instance-methods. Unfortunately it exploded in the code, and had to refactor quite a bit.
There are a couple of places (e.g: RLP methods, HashAlogrithm methods) where creating a bound function is not possible because the interpreter is not available. However they are OK for now, since the underlying values are not resources and would have no impact on behaviour. i.e: conceptually wrong, but functionality wise no difference.
Left TODOs in these places, we can try to refactor these later.
On a side note, I also renamed "NewHostFunction" to "NewStaticHostFunction", to avoid naming chaos (bound, unbound, unmetered-bound, unmetered-unbound, etc.)
masterbranchFiles changedin the Github PR explorer