Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2827 Add improvment WebAssembly Wrap Error #2889

Open
wants to merge 1 commit into
base: bastian/webassembly
Choose a base branch
from

Conversation

PratikDhanave
Copy link
Contributor

Closes and work towards #2827

Description

Wrap user-errors produced by WebAssembly VM as Cadence user errors.
Requires defining abstract user errors that are VM-agnostic. Define in interpreter/errors.go, as errors.UserError


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@PratikDhanave PratikDhanave marked this pull request as ready for review October 20, 2023 10:05
@PratikDhanave
Copy link
Contributor Author

@turbolent @SupunS Thank You for Providing opportunity to contribute.
This is my first PR towards idea of adding a WebAssembly API to Cadence.
@turbolent @SupunS can you please give first review on PR ?
I want to know I am going in right approach.
Thank You

@PratikDhanave PratikDhanave force-pushed the PratikDhanave/2827-WebAssemblyWrapError branch 5 times, most recently from d88283b to 7efbb3b Compare October 20, 2023 11:17
@PratikDhanave PratikDhanave force-pushed the PratikDhanave/2827-WebAssemblyWrapError branch from 7efbb3b to 82dd670 Compare October 20, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant