PoC: WebAssembly API #2760
Draft
PoC: WebAssembly API #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow instantiating a module without imports and allow access to function exports
Base automatically changed from
bastian/type-code-generator-for-stdlib
to
feature/stable-cadence
September 1, 2023 20:29
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/stable-cadence commit 544aed4 Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2760 +/- ##
==========================================
- Coverage 79.97% 79.96% -0.02%
==========================================
Files 344 347 +3
Lines 81213 81553 +340
==========================================
+ Hits 64949 65210 +261
- Misses 13959 14020 +61
- Partials 2305 2323 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
turbolent
commented
Sep 1, 2023
turbolent
commented
Sep 1, 2023
6 tasks
|
hi @turbolent thank you for adding a WebAssembly API to Cadence. |
turbolent
changed the base branch from
feature/stable-cadence
to
bastian/sync-stable-cadence-10
Base automatically changed from
bastian/sync-stable-cadence-10
to
feature/stable-cadence
October 5, 2023 23:13
|
Ah ignore, it is already on a feature branch. I didn't notice it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2853
Description
This PoC explores the idea of adding a WebAssembly API to Cadence, i.e. exposing a WebAssembly VM to Cadence programs.
The PRs adds:
A
WebAssemblycontract with an API inspired by the WebAssembly JavaScript Interface. The beginnings of the API support module instantiation, without imports, and access to function exports withi32andi64types.An implementation of the WebAssembly API based on wasmtime. The VM is not yet configured for metering and limits have not been set.
A test case which demonstrates loading a simple
add(i32, i32) -> i32function, calling it with CadenceUInt32values, and getting back the result as a CadenceUInt32.https://github.com/onflow/cadence/pull/2760/files#diff-27b18491bc5b8a8ea5aabf7d9453695aef776c0858db4c84eea0963717c296b5R201-R216
masterbranchFiles changedin the Github PR explorer