Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint #1200

Merged
merged 1 commit into from Oct 27, 2021
Merged

Update golangci-lint #1200

merged 1 commit into from Oct 27, 2021

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Oct 27, 2021

Description

@dsainati1 reported that linting crashes on Go 1.17 on macOS.

...
golang.org/x/sys/unix.IoctlGetTermios(...)
	/Users/sainati/go/pkg/mod/golang.org/x/sys@v0.0.0-20210403161142-5e06dd20ab57/unix/ioctl.go:73
github.com/mattn/go-isatty.IsTerminal(0x4b71658)
	/Users/sainati/go/pkg/mod/github.com/mattn/go-isatty@v0.0.12/isatty_bsd.go:10 +0x50 fp=0xc00020f930 sp=0xc00020f8c0 pc=0x42cbed0
github.com/fatih/color.init()
	/Users/sainati/go/pkg/mod/github.com/fatih/color@v1.10.0/color.go:21 +0x7a fp=0xc00020f968 sp=0xc00020f930 pc=0x42ce41a
runtime.doInit(0x53ea140)
...

It looks like mattn/go-isatty#66 fixed this.

Update golangci-lint to the latest version.

Running go mod tidy results in clean builds of golangci-lint and the maprangecheck linter, but fails to run with

ERRO Unable to load custom analyzer maprangecheck:tools/maprangecheck/maprangecheck.so, plugin.Open("/Users/bastian/Documents/work/cadence/tools/maprangecheck/maprangecheck"): plugin was built with a different version of package golang.org/x/sys/execabs

So commit the full go.sum files as-is.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Oct 27, 2021
Copy link
Contributor

@dsainati1 dsainati1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and it fixes the issue. Thanks!

Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@turbolent turbolent merged commit 23a917f into master Oct 27, 2021
@turbolent turbolent deleted the bastian/update-golangci-lint branch October 27, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants