Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[semver:patch] fixes install_promtool command #8

Merged
merged 2 commits into from Mar 3, 2021

Conversation

dgeorges
Copy link
Contributor

@dgeorges dgeorges commented Mar 2, 2021

SEMVER Update Type:

  • Major
  • Minor
  • Patch

Description:

fixes error during promtool install.
see prometheus/prometheus#8480

Motivation:

fixes:

#!/bin/bash -eo pipefail
go get github.com/prometheus/prometheus/cmd/promtool
# github.com/prometheus/prometheus/cmd/promtool
/go/src/github.com/prometheus/prometheus/cmd/promtool/main.go:642:35: not enough arguments in call to api.LabelValues
	have (context.Context, string, time.Time, time.Time)
	want (context.Context, string, []string, time.Time, time.Time)

Exited with code exit status 2

@dgeorges dgeorges requested a review from a team as a code owner March 2, 2021 21:58
@dgeorges dgeorges merged commit 01cfed2 into main Mar 3, 2021
@dgeorges dgeorges mentioned this pull request Mar 8, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants