Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[semver:minor] add ability to specify version of prom/am tool install binaries #10

Merged
merged 2 commits into from Sep 8, 2021

Conversation

dgeorges
Copy link
Contributor

@dgeorges dgeorges commented Sep 8, 2021

SEMVER Update Type:

  • Major
  • Minor
  • Patch

Description:

Allow for the user of the orb to specify which version of the tool to install.

Motivation:

Builds failing to install am tools because of dependencies missing.

installing amtool
/go/src/github.com/prometheus/alertmanager/notify/notify.go:24:2: cannot find package "github.com/cespare/xxhash" in any of:
	/usr/local/go/src/github.com/cespare/xxhash (from $GOROOT)
	/go/src/github.com/cespare/xxhash (from $GOPATH)

This is the cause of breaking changes. Allow for the user of the orb to specify which version of the tool to install.
see: prometheus/prometheus#8480

Closes Issues:

https://jira.onemedical.com/browse/SRE-529

Checklist:

  • All new jobs, commands, executors, parameters have descriptions.
  • Usage Example version numbers have been updated.

CLA Acceptance

Please indicate your acceptance of the CLA below:

  • I ACCEPT -- I have sole ownership of intellectual property rights to my Contribution and I am not making a submission in the course of work for my employer.

  • I ACCEPT -- I am making the Contribution in the course of my work for my employer, [EMPLOYER NAME]. I have permission from [EMPLOYER NAME] to make the Contribution under the CLA.

@dgeorges dgeorges changed the title [semver:minor] add ability to versioning install of prom/am tool binaries [semver:minor] add ability to specify version of prom/am tool install binaries Sep 8, 2021
@dgeorges dgeorges marked this pull request as ready for review September 8, 2021 18:34
@dgeorges dgeorges requested a review from a team as a code owner September 8, 2021 18:34
@dgeorges dgeorges merged commit 5be68aa into main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants