Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change black version in .pre-commit-config.yaml. #340

Merged
merged 3 commits into from Aug 26, 2020

Conversation

pereman2
Copy link
Contributor

@pereman2 pereman2 commented Aug 26, 2020

Change version and reformat with the new changes.
I changed to 20.8b1 version in black because as mentioned in psf/black#420:

Notably it gives the illusion that the latest version is being used but in reality it uses the version at install time.

Copy link
Owner

@omry omry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@@ -5,10 +5,10 @@ repos:
- id: isort

- repo: https://github.com/psf/black
rev: stable
rev: 20.8b1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nasty.

@omry omry merged commit 2579bd8 into omry:master Aug 26, 2020
pereman2 added a commit to pereman2/omegaconf that referenced this pull request Aug 27, 2020
* black language version 3.8

* black version

* reformat
@pereman2 pereman2 deleted the versionblack branch August 27, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants