Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PENG-2070] Allow files to be renamed in upsert routes in Jobbergate API #553

Merged
merged 2 commits into from
May 10, 2024

Conversation

fschuch
Copy link
Member

@fschuch fschuch commented Apr 30, 2024

What

  • A new field was added to the upsert routes for the previous file name
  • When the previous name doesn't match the new name, the file is renamed in the storage
  • Fixed upsert on job-script files returning no data
  • Unit tests were updated

Why

We need the users to be able to rename their files when they are being upserted.

Task: https://app.clickup.com/t/18022949/PENG-2070


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (5488fae) to head (d953d3a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
- Coverage   92.21%   92.19%   -0.02%     
==========================================
  Files          82       82              
  Lines        4431     4447      +16     
==========================================
+ Hits         4086     4100      +14     
- Misses        345      347       +2     
Flag Coverage Δ
agent 93.51% <ø> (ø)
api 95.43% <ø> (-0.08%) ⬇️
cli 88.25% <ø> (ø)
core 95.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fschuch fschuch requested a review from dusktreader May 8, 2024 19:28
@fschuch fschuch merged commit 2309ca5 into main May 10, 2024
12 checks passed
@fschuch fschuch deleted the fschuch/PENG-2070--rename-files-on-upsert branch May 10, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants