feat: Windows test, FFI test, and commit msg CI #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the CI configuration by: - Adding testing for Windows - Adding testing for CCI code on Ubuntu and Windows - Adding checking for conventional commit format in commit messages - Upgrading from checkout v2 to v4 across the board. Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
alilleybrinker
force-pushed
the
alilleybrinker/ci-upgrades
branch
from
bee435f
to
74b556b
Compare
This commit fixes a transient issue where cbindgen would sometimes pick up and try to build gitoid:0.3.0 instead of the current version gitoid:0.4.0. This was happening because the omnibor crate imported gitoid:0.3.0, and the two names would both appear in the output of `cargo metadata`. cbindgen would use the first one that appeared, which was sometimes gitoid:0.4.0 and sometimes gitoid:0.3.0. If it was the older version, then everything would break. This isn't really a long term fix, so there's a need to do more in the future to stop this from happening again. For now this is enough. Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
Haha forgot to do this when I made the replacement. We weren't really using the features of Make so I thought it would be better to just use a shell script. This commit updates CI to use that script. Signed-off-by: Andrew Lilley Brinker <alilleybrinker@gmail.com>
|
Looks like this is the cbindgen issue we were encountering: mozilla/cbindgen#900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the CI configuration by: