Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rescue OAuth2 Timeout errors #166

Closed
wants to merge 1 commit into from
Closed

Rescue OAuth2 Timeout errors #166

wants to merge 1 commit into from

Commits on Jun 5, 2023

  1. Rescue OAuth2 Timeout errors 

    * This fix was originally proposed with a different solution via this PR: omniauth#129
* The conclusion there was that we should not rescue Faraday errors because
  Faraday is not a direct dependency of OAuth2.
* Instead, best to rescue Faraday errors on OAuth2, then rescue OAuth2 errors here
* Those changes to OAuth2 were made here: https://gitlab.com/oauth-xx/oauth2/-/merge_requests/604
* And released as part of OAuth2 gem version 2.0.2: https://gitlab.com/oauth-xx/oauth2/-/blob/866dc365bfe0d64f6cc56295a38ccd5b24143836/CHANGELOG.md#L74
    @jessieay
    jessieay committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    fd7cb7d View commit details
    Browse the repository at this point in the history