Include the received access token's scope in the 'extra' hash #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [GitHub's documentation](https://developer.github.com/apps/building-oauth-apps/understanding-scopes-for-oauth-apps/#requested-scopes-and-granted-scopes): > The scope attribute lists scopes attached to the token that were granted > by the user. Normally, these scopes will be identical to what you > requested. However, users can edit their scopes, effectively granting > your application less access than you originally requested. Also, users > can edit token scopes after the OAuth flow is completed. You should be > aware of this possibility and adjust your application's behavior > accordingly. Therefore, include the scope returned with the OAuth token in the 'extra' hash generated for the omniauth callback. According to the OAuth2 gem's code, extra params returned with the access token response can accessed via indexing on the AccessToken class: https://github.com/oauth-xx/oauth2/blob/58471c95c5473d9a494e45534df96f0cf935a2bb/lib/oauth2/access_token.rb#L60-L65
davebrace
force-pushed
the
include-token-scope-in-extra
branch
from
471a791
to
1b3a35c
Compare
davebrace
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to GitHub's documentation:
Therefore, include the scope returned with the OAuth token in the
'extra' hash generated for the omniauth callback.
According to the OAuth2 gem's code, extra params returned with the
access token response can accessed via indexing on the AccessToken
class:
https://github.com/oauth-xx/oauth2/blob/58471c95c5473d9a494e45534df96f0cf935a2bb/lib/oauth2/access_token.rb#L60-L65