Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added globalSearchable check for ArrayAdapter #341

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

ToshY
Copy link
Contributor

@ToshY ToshY commented Apr 30, 2024

Fixes #340

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (4f3dcb4) to head (6115808).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files          37       37           
  Lines         975      975           
=======================================
  Hits          922      922           
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ToshY
Copy link
Contributor Author

ToshY commented Apr 30, 2024

Hey @curry684 👋

Would be nice if you could spare some time to review this.

Thanks in advance.

@ToshY ToshY closed this May 6, 2024
@curry684
Copy link
Member

curry684 commented May 7, 2024

Hey @ToshY, I was away on holiday last week. Why did you close the PR, is it wrong or irrelevant?

@curry684 curry684 reopened this May 7, 2024
@ToshY
Copy link
Contributor Author

ToshY commented May 8, 2024

Well, I intended to use the bundle for a longer period of time, but after a week of fiddling around with it I realised I don't need most of the functionality/complexitiy that the bundle provides. So I decided I no longer needed to use it and I just could write the minimal code needed to work with the js datatable library.

While the fix worked (tested manually), I'm not sure if this is relevant to other users as I'm guessing the majority is using the other adapters anyway. So if you still think it's relevant, it can be merged. For me however it has become irrelevant.

@curry684
Copy link
Member

I'll merge it anyway if it's tested to be fixed, looks good anyway although the ArrayAdapter is formally unsupported and just for testing/prototyping (in most cases a custom AbstractAdapter is less work, faster and tons more memory efficient).

@curry684 curry684 merged commit 4cb4874 into omines:master May 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArrayAdapter searchable and globalSearchable don't work
2 participants