Fix jsx-indent single line jsx

Also adds test
omerzach · Mar 21, 2017 · b5a2ff4 · b5a2ff4
1 parent 966532d
commit b5a2ff4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/rules/jsx-indent.js b/lib/rules/jsx-indent.js
@@ -325,7 +325,7 @@ module.exports = {
         checkNodesIndent(node, parentNodeIndent + indentSize);
       },
       Literal: function(node) {
-        if (!node.parent || node.parent.type !== 'JSXElement') {
+        if (!node.parent || node.parent.type !== 'JSXElement' || node.loc.start.line === node.parent.loc.start.line) {
           return;
         }
         var parentElementIndent = getOpeningElementIndent(node.parent.openingElement);

diff --git a/tests/lib/rules/jsx-indent.js b/tests/lib/rules/jsx-indent.js
@@ -451,6 +451,14 @@ ruleTester.run('jsx-indent', rule, {
     ].join('\n'),
     options: [2],
     parserOptions: parserOptions
+  }, {
+    code: [
+      'function foo() {',
+      '  <span>Text</span>',
+      '}'
+    ].join('\n'),
+    options: [2],
+    parserOptions: parserOptions
   }],
 
   invalid: [{