Webpack 5 upgrade #450

will-moore · 2023-04-12T12:28:12Z

Updated webpack, aurelia and lots of dependencies.

To test:

check app works on "merge-ci"
Test local development workflow - follow updated instructions in README (workflow hasn't changed, but hopefully new instructions are easier to follow)

Various issues and tips from pages:
ome/omero-parade@115481e
https://webpack.js.org/migrate/5/
https://stackoverflow.com/questions/40379139/cannot-find-module-webpack-bin-config-yargs
aurelia/aurelia#982
aurelia/webpack-plugin#166
webpack/webpack-dev-server#1501
https://webpack.js.org/configuration/module/#ruleuse
https://webpack.js.org/configuration/dev-server/#devserverproxy
https://www.npmjs.com/package/expose-loader

snoopycrimecop · 2023-04-17T11:14:58Z

Conflicting PR. Removed from build OMERO-plugins-push#1492. See the console output for more details.
Possible conflicts:

PR Bump node-forge and webpack-dev-server #435 dependabot[bot] 'Bump node-forge and webpack-dev-server'
- package.json
- package-lock.json
PR Bump qs, body-parser and express #437 dependabot[bot] 'Bump qs, body-parser and express'
- package-lock.json
PR Bump express from 4.17.1 to 4.18.2 #438 dependabot[bot] 'Bump express from 4.17.1 to 4.18.2'
- package-lock.json
PR Mirroring support #439 barrettMCW 'Mirroring support'
- src/index-dev.html
PR Bump ua-parser-js from 0.7.31 to 0.7.33 #444 dependabot[bot] 'Bump ua-parser-js from 0.7.31 to 0.7.33'
- package-lock.json
PR Bump jszip from 3.7.0 to 3.8.0 #445 dependabot[bot] 'Bump jszip from 3.7.0 to 3.8.0'
- package.json
- package-lock.json

--conflicts

snoopycrimecop · 2023-04-17T11:40:43Z

Conflicting PR. Removed from build OMERO-plugins-push#1493. See the console output for more details.
Possible conflicts:

PR Mirroring support #439 barrettMCW 'Mirroring support'
- src/index-dev.html

~~--conflicts~~ Conflict resolved in build OMERO-plugins-push#1495. See the console output for more details.

This fixes ECONNREFUSED errors when using localhost

ankit-gautam23

LGTM

jburel · 2023-06-05T20:28:10Z

README.rst


-**Notes**:
+You will usually want to have OMERO-iviewer installed on a local omero-web server,


OMERO.iviewer

jburel · 2023-06-05T20:28:34Z

README.rst


-**Notes**:
+You will usually want to have OMERO-iviewer installed on a local omero-web server,
+to test the JavaScript built above. NB: first uninstall iviewer if already installed,


OMERO.iviewer

jburel · 2023-06-05T20:28:54Z

README.rst


+The dev build of iviewer will attempt to connect to a local OMERO server at http://127.0.0.1:4080.


OMERO.iviewer

jburel · 2023-06-05T20:29:08Z

README.rst


-The initial data type (e.g. image, dataset, well) and its respective ID can be set/changed
+The iviewer will try to open an Image or other data from your local server, using IDs specified


OMERO.iviewer

snoopycrimecop · 2023-06-06T01:00:33Z

Conflicting PR. Removed from build OMERO-plugins-push#157. See the console output for more details.
Possible conflicts:

PR viewport URL includes z-plane #372 will-moore 'viewport URL includes z-plane'
- README.rst
PR Add release process to README #420 will-moore 'Add release process to README'
- README.rst
PR Mirroring support #439 barrettMCW 'Mirroring support'
- README.rst
- src/index-dev.html

--conflicts

snoopycrimecop · 2023-06-06T08:57:28Z

Conflicting PR. Removed from build OMERO-plugins-push#158. See the console output for more details.
Possible conflicts:

PR Add release process to README #420 will-moore 'Add release process to README'
- README.rst

~~--conflicts~~ Conflict resolved in build OMERO-plugins-push#159. See the console output for more details.

jburel · 2023-06-06T21:15:02Z

plugin/llab_omero_iviewer.egg-info/SOURCES.txt

Why is this included?

jburel · 2023-06-07T07:27:24Z

llab_omero_iviewer.egg-info should not be there

will-moore · 2023-06-09T08:26:12Z

Removed llab_omero_iviewer.egg-info

will-moore · 2023-06-20T14:57:47Z

Changes made as suggested. However, I'm not sure we really need to use OMERO.iviewer every time. It's like using someone's First and Last Name, which is fine when you first refer to them, but is a bit of a mouthful every time.

jburel · 2023-06-20T18:46:33Z

Thanks

will-moore added 3 commits April 12, 2023 12:02

Upgrade to last webpack 4 version

4a0c376

Updrade webpack 5

cba1e56

Upgrade to webpack 5

5c350b5

revert change to index-dev.html - avoid merge conflict

d0bdde3

proxy http://127.0.0.1 instead of localhost

e507727

This fixes ECONNREFUSED errors when using localhost

ankit-gautam23 approved these changes Apr 21, 2023

View reviewed changes

will-moore added 2 commits May 12, 2023 16:27

More version bumps in package.json and package-lock.json

17a4e75

Update dev info in README

991538c

jburel reviewed Jun 5, 2023

View reviewed changes

README.rst Outdated

**Notes**:

You will usually want to have OMERO-iviewer installed on a local omero-web server,

Copy link

Member

jburel Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMERO.iviewer

jburel reviewed Jun 5, 2023

View reviewed changes

README.rst Outdated

The dev build of iviewer will attempt to connect to a local OMERO server at http://127.0.0.1:4080.

Copy link

Member

jburel Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMERO.iviewer

jburel reviewed Jun 5, 2023

View reviewed changes

Merge remote-tracking branch 'origin/master' into webpack_5_upgrade

772ad02

Use underscore for description_file

efb5348

jburel mentioned this pull request Jun 6, 2023

Build #452

Closed

will-moore added 3 commits June 6, 2023 13:04

Try to exclude __pycache__ from build

aca3e90

flake8 fix for setup.py

8d3faa0

Revert attempt to exclude __pycache__

338ab13

jburel reviewed Jun 6, 2023

View reviewed changes

plugin/llab_omero_iviewer.egg-info/SOURCES.txt Outdated

Copy link

Member

jburel Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this included?

remove llab_omero_iviewer.egg-info

e1d8a89

Use OMERO.iviewer everywhere

28143de

jburel merged commit da9f9e9 into ome:master Jun 20, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Webpack 5 upgrade #450

Webpack 5 upgrade #450

will-moore commented Apr 12, 2023 •

edited

snoopycrimecop commented Apr 17, 2023

snoopycrimecop commented Apr 17, 2023 •

edited

ankit-gautam23 left a comment

jburel Jun 5, 2023

jburel Jun 5, 2023

jburel Jun 5, 2023

jburel Jun 5, 2023

snoopycrimecop commented Jun 6, 2023

snoopycrimecop commented Jun 6, 2023 •

edited

jburel Jun 6, 2023

jburel commented Jun 7, 2023

will-moore commented Jun 9, 2023

will-moore commented Jun 20, 2023

jburel commented Jun 20, 2023


		Notes:
		You will usually want to have OMERO-iviewer installed on a local omero-web server,


		The dev build of iviewer will attempt to connect to a local OMERO server at http://127.0.0.1:4080.


		The initial data type (e.g. image, dataset, well) and its respective ID can be set/changed
		The iviewer will try to open an Image or other data from your local server, using IDs specified

Webpack 5 upgrade #450

Webpack 5 upgrade #450

Conversation

will-moore commented Apr 12, 2023 • edited

snoopycrimecop commented Apr 17, 2023

snoopycrimecop commented Apr 17, 2023 • edited

ankit-gautam23 left a comment

Choose a reason for hiding this comment

jburel Jun 5, 2023

Choose a reason for hiding this comment

jburel Jun 5, 2023

Choose a reason for hiding this comment

jburel Jun 5, 2023

Choose a reason for hiding this comment

jburel Jun 5, 2023

Choose a reason for hiding this comment

snoopycrimecop commented Jun 6, 2023

snoopycrimecop commented Jun 6, 2023 • edited

jburel Jun 6, 2023

Choose a reason for hiding this comment

jburel commented Jun 7, 2023

will-moore commented Jun 9, 2023

will-moore commented Jun 20, 2023

jburel commented Jun 20, 2023

will-moore commented Apr 12, 2023 •

edited

snoopycrimecop commented Apr 17, 2023 •

edited

snoopycrimecop commented Jun 6, 2023 •

edited