Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v0.4 sample data #34

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Add v0.4 sample data #34

merged 1 commit into from
Mar 2, 2022

Conversation

will-moore
Copy link
Member

cc @jburel

@joshmoore
Copy link
Member

All samples were correctly detected with ome/ZarrReader#8 as long as I renamed them to $something.ome.zarr.

@sbesson sbesson added this to In progress in OME-NGFF 0.4 Feb 22, 2022
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the comment in #34 (comment) regarding the folder name, the only other aspect that my testing raised is that the content of https://github.com/ome/ome_zarr_test_suite/tree/main/data corresponds to the output of bioformats2raw.

The main issue with this layout is that the top-level group is not specified in the OME-NGFF specification although work is starting to rationalize this concept - see ome/ngff#104. As a concrete result, the tests need also operating on the multiscales group

path: data/64x64-fake-v0.1/0

No objections to merging this but as a follow-up I would propose to open a PR (and a discussion) to drop this intermediate layer and add a .zarr suffix i.e. data/64x64-fake-v0.4/0 -> data/64x64-fake-v0.4.zarr. Any immediate objection?

OME-NGFF 0.4 automation moved this from In progress to Reviewer approved Mar 1, 2022
@sbesson sbesson merged commit 5163d5c into ome:main Mar 2, 2022
OME-NGFF 0.4 automation moved this from Reviewer approved to Done Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants