Add standard build metadata to the JAR manifest #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
requested review from
joshmoore and
dgault
and removed request for
joshmoore
|
With this PR the MANIFEST.MF is included with the commit revision, implementation version, build date etc. PR looks good to merge. |
dgault
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on reviewing #8, I found it hard to identify the version of the commit used to produced a deployed ZarrReader JAR.
This should add the standard build metadata to
MAVEN/MANIFEST.MFincluding the commit revision, similarly to what is being done in Bio-Formats