Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate tests in maven #11

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Activate tests in maven #11

merged 1 commit into from
Nov 29, 2021

Conversation

joshmoore
Copy link
Member

By adding the testSourceDirectory, the mvn test
target can be used in intellij to run tests. This
detected an NPE on axes that I've fixed here
though it would be more appropriate for gh-8.

By adding the testSourceDirectory, the `mvn test`
target can be used in intellij to run tests. This
detected an NPE on `axes` that I've fixed here
though it would be more appropriate for omegh-8.
@joshmoore joshmoore requested review from dgault and removed request for dgault November 26, 2021 15:56
@dgault
Copy link
Member

dgault commented Nov 29, 2021

Adding the test directory now lets the mvn test target run correctly.
As there is no conflicts lets get this merged now with the axes change also.

@dgault dgault merged commit 08a1c6c into ome:main Nov 29, 2021
@joshmoore joshmoore deleted the fix-tests branch November 29, 2021 14:12
@sbesson sbesson added this to Done in OME-NGFF 0.4 Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants