New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Electron 15 #812
Upgrade to Electron 15 #812
Conversation
Thanks for your efforts! I quickly tested it on my Macbook and it works but the startup time is way slower. It takes around 10s for the app to respond when triggering the global shortcut to show the window. Any idea what that could be? |
I've tested both the So I have no idea why your Macbook takes 10 seconds, can you try to switch back and forth and see if it really is this branch? Maybe your macbook had a bad day, or maybe there's a mac-only issue. |
Hi, any update on this? I really valued the dictionary feature, so wish to see #807 resolved. Seems this is the easiest/best solution to that, with very little potential downside. |
No success so far. I disabled all plugins to see if one of the plugins is causing the issue but it's still the same. I measured the time it takes to create the main window and it's arond 15s which is a big downside in my opinion ;) I don't want to merge this PR as long as the long startup time is an issue. Unfortunately currently I have very little time to look into this issue, so let's hope that someone might find a clue. |
I want to introduce myself by first thanking you, @oliverschwendener, as well as everyone else who has contributed to ueli development; it has become an essential application for me! Secondly, that I am a novice programmer especially with respect to node.js development. However, because I use and enjoy ueli so much and miss the dictionary functionality, I want to contribute in anyway I can. That being, said, and while this is not much, I want to say that after checking out this PR and testing on my machine, I had no issues with startup time delays: Using the global shortcut, the main window appears just as quickly as it does with the stable version and #807 is resolved. I am running it on Windows 11 so perhaps the issue is MacOS specific as @NotWearingPants suggested? |
Somehow I managed to upgrade electron to version 17 without having the startup lag issue on macOS. So i consider this issue as resolved and I will close this PR. Thanks alot again for your efforts and the contribution and sorry that we were not able to merge your work but it's highly appreciated! |
Fixes #807 and also brings ueli back to supported Electron versions (the latest!).
I've gone over all of Electron's breaking changes up to version 15, and the only ones affecting ueli are
contextIsolation
which defaults totrue
since v12, and theelectron.remote
module which is deprecated since v12 and removed in v14.What I did:
electron
to^15.1.0
, the latest versioncontextIsolation: false
to keep the current behavior for nowenableRemoteModule: true
until now becauseelectron-store
useselectron.remote
.But the
remote
module was removed in v14, so I've updatedelectron-store
to^8.0.1
(latest) which now uses IPC instead ofremote
.electron-store.Store
is generic on the type of the settings, butelectron-store
s update changed the default fromany
tounknown
, so I had to specify explicit types for the store in both config & favorites.electron-store
also updated it's dependencytype-fest
.type-fest
had an import of typescript'sesnext
definitions, so ueli's usage ofString.replaceAll
compiled, buttype-fest
removed this import (Fix TS type reference sindresorhus/type-fest#187) which is good, and so now we must specify we depend onesnext.string
intsconfig.json
forreplaceAll
.