__proto__ disappears from the inverted index if you serialize an index that was loaded from a serialized JSON blob #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found while using lunr that __proto__ can slip through the serialization process if you're serializing an index that was itself loaded from a serialized index - it might not be a bad idea to make sure that serializing an index loaded from a JSON blob serializes to the exact same JSON blob (well, forgiving things like a change in the order of the keys)
Fixes the issue where __proto__ is dropped from the inverted index after a second deserializatoin
hoelzro
changed the title
hoelzro
added a commit
to hoelzro/tw-full-text-search
that referenced
this pull request
Oct 15, 2018
|
I'll put together a release that includes this change just now. Changes are in master. Thanks. |
|
2.3.4 has been published to NPM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test and fix included - details are in the commit messages