Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Bulk processor retries indefinitely on failure #1661

Open
wants to merge 2 commits into
base: release-branch.v7
Choose a base branch
from
Open

Fix: Bulk processor retries indefinitely on failure #1661

wants to merge 2 commits into from
+73 −0

Commits on Feb 2, 2023

  1. Fix: Bulk processor retries indefinitely on failure 

    When all retries are exhausted the worker internal requests buffer needs to be
cleared in failure scenarios. That is required because the commitFunc (and
consequently the underlying BulkService.Do call) doesn't reset it when some error
happens. Without clearing the internal buffer the worker will continue sending
the same requests on the following rounds of execution.

Kudos for this solution goes to @rwynn and @raiRaiyan .

Resolves olivere#1278
    @rafaeljusto
    rafaeljusto committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    91b8a1a View commit details
    Browse the repository at this point in the history

  2. Fix comment typos

    @rafaeljusto
    rafaeljusto committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    a2de1fe View commit details
    Browse the repository at this point in the history