Change type of Package.rust_version from VersionReq to Version #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2023
Does cargo metadata actually get such truncated version numbers? I'd have hoped cargo emits full versions, even if it is more lenient in Cargo.toml |
|
Yes it does. I tested it ... |
As per the Cargo Book[1] the `rust-version` must: > be a bare version number with two or three components; > it cannot include semver operators or pre-release identifiers. VersionReq therefore obviously is the wrong type since it describes[2]: > the intersection of some version comparators such as `>=1.2.3, <1.8` It doesn't make much sense to deserialize strings that explicitly "cannot include semver operators" as a vector of comparison operators. While the Version type's Deserialize implementation requires three components, we can just use a custom deserialize function to deserialize 1.2 as 1.2.0. This commit introduces such. [1]: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field [2]: https://docs.rs/semver/1.0.7/semver/struct.VersionReq.html
not-my-profile
force-pushed
the
use-Version-for-rust_version
branch
from
09bdf9e
to
535ab32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the Cargo Book1 the
rust-versionmust:VersionReq therefore obviously is the wrong type since it describes2:
It doesn't make much sense to deserialize strings that explicitly "cannot include semver operators" as a vector of comparison operators.
While the Version type's Deserialize implementation requires three components, we can just use a custom deserialize function to deserialize 1.2 as 1.2.0. This commit introduces such.