bump derive_builder dependency to v0.12 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dependencies of this crate have migrated to the 2021 Edition, which was only stabilized in Rust 1.56.0.
|
sgtm. You need to address the clippy failures though :) Maybe we should also move this crate to the 2021 edition |
|
The clippy warning should now be addressed. I'm not sure if bumping to the 2021 edition would be necessary, unless you plan to use some features that are 2021-or-later-only. But at least it won't necessitate bumping the MSVR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.12.0 of the
derive_buildercrate introduces only a small breaking change which does not affect this crate.I have also bumped the MSRV of
cargo_metadatato 1.56.0 - I tried compiling this crate with the currently set 1.42.0, which fails (even before bumping derive_builder to v0.12) because some of this crate's dependencies have moved to the Rust 2021 edition (which was stabilized in Rust 1.56.0).