Remove unnecessary cargo-semver-checks comment from main.yml
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uh... @obi1kenobi recently did #227 Without having looked at the PR here, how do these changes relate? |
|
Ah sorry, I forgot to clean up the old comment. I upgraded the release-side one to the v2 action already: 6489ef6 Let's just delete the commented-out lines. |
obi1kenobi
reviewed
May 3, 2023
|
Oh, and my mistake is that I haven't checked the other workflow file, sorry for that! |
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
mgr0dzicki
changed the title
cargo-semver-checks-action to run semver checkscargo-semver-checks comment from main.yml
obi1kenobi
approved these changes
May 3, 2023
No worries, thanks to your PR we've now deleted the problematic lines so we won't have this confusion again! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm one of the contributors of cargo-semver-checks. I noticed the use of
cargo-semver-checks-actionthat is commented out in your CI.Since we've recently released a new, completely rebuilt V2 version of the GitHub action, you can now conveniently use it in your workflow. It fixes the problems of outdated V1 and includes huge improvements of the running time. I suggested adding a job
semver-checks, which seems to work well now. I hope it will be useful!