Add missing manifest_path field to Artifact #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did overlook that the test samples need to be fixed |
|
Okay so apperantaly |
|
Nevermind I figure it out, I also added the proper entry to the changelog. |
oli-obk
reviewed
Jul 2, 2022
src/messages.rs
Outdated
| @@ -34,6 +34,8 @@ pub struct ArtifactProfile { | |||
| pub struct Artifact { | |||
| /// The package this artifact belongs to | |||
| pub package_id: PackageId, | |||
| /// Path containing the `Cargo.toml` | |||
There was a problem hiding this comment.
I think it's the path to the Cargo.toml. the current doc comment sounds like it would point to the parent folder
There was a problem hiding this comment.
Yeah good catch, I'll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187