jetty#5150 - Code style fix and connect timeout docs update

Signed-off-by: Oleg Mozzhechkov <oleg.mozzhechkov@gmail.com>
olegmoz · Aug 13, 2020 · 32fe19a · 32fe19a
1 parent bffd6a2
commit 32fe19a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java b/jetty-client/src/main/java/org/eclipse/jetty/client/HttpClient.java
@@ -690,7 +690,7 @@ public void setName(String name)
     }
 
     /**
-     * @return the max time, in milliseconds, a connection can take to connect to destinations
+     * @return the max time, in milliseconds, a connection can take to connect to destinations. Zero value means infinite timeout.
      */
     @ManagedAttribute("The timeout, in milliseconds, for connect() operations")
     public long getConnectTimeout()
@@ -699,7 +699,7 @@ public long getConnectTimeout()
     }
 
     /**
-     * @param connectTimeout the max time, in milliseconds, a connection can take to connect to destinations
+     * @param connectTimeout the max time, in milliseconds, a connection can take to connect to destinations. Zero value means infinite timeout.
      * @see java.net.Socket#connect(SocketAddress, int)
      */
     public void setConnectTimeout(long connectTimeout)

diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/ManagedSelector.java b/jetty-io/src/main/java/org/eclipse/jetty/io/ManagedSelector.java
@@ -888,7 +888,7 @@ class Connect implements SelectorUpdate, Runnable
         {
             this.channel = channel;
             this.attachment = attachment;
-            final long timeout = ManagedSelector.this._selectorManager.getConnectTimeout();
+            long timeout = ManagedSelector.this._selectorManager.getConnectTimeout();
             if (timeout > 0)
                 this.timeout = ManagedSelector.this._selectorManager.getScheduler().schedule(this, timeout, TimeUnit.MILLISECONDS);
             else