chore: clean up type test setup #1511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Apr 19, 2024
Comment on lines
-184
to
-192
| "name": "Debug TSD", | ||
| "program": "${workspaceFolder}/node_modules/jest/bin/jest", | ||
| "args": [ | ||
| "--runInBand", | ||
| "--no-cache", | ||
| "--collectCoverage=false", | ||
| "--config=jest.tsd.js", | ||
| "--testTimeout=120000" | ||
| ], |
There was a problem hiding this comment.
This config does nothing anymore. It can be removed as well.
Is it worth to have launch configuration for type tests? I mean, in this case there is no run time. Type testing only performs static analysis (similar to tsc or eslint), so there no way to have breakpoints or to do any data inspection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #1510
This PR:
tsdkey frompackage.json;.tst.tsto match the defaulttestFileMatchpattern of TSTyche (this means thattstyche.config.jsonis no longer needed).